[RN][Jest] Fix tests for React 19#45007
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/fix_tests
branch
from
c7fc674 to
66d75b0
Compare
robhogan
approved these changes
Jun 17, 2024
Contributor
There was a problem hiding this comment.
Don't need the returns here, otherwise LGTM
Suggested change
| return await ReactTestRenderer.act(() => { return ReactTestRenderer.create(<App />) }) | |
| await ReactTestRenderer.act(() => { | |
| ReactTestRenderer.create(<App />); | |
| }); |
cipolleschi
force-pushed
the
cipolleschi/fix_tests
branch
from
66d75b0 to
ec94b3b
Compare
cipolleschi
force-pushed
the
cipolleschi/fix_tests
branch
from
ec94b3b to
31ba14c
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 16380aa. |
|
This pull request was successfully merged by @cipolleschi in 16380aa. When will my fix make it into a release? | How to file a pick request? |
edtech000001
added a commit
to edtech000001/amixos
that referenced
this pull request
Apr 26, 2026
…t crash RN 0.74.1's privacy_manifest_utils.rb crashes during pod install with "undefined method `each' for nil:NilClass" when one of the dependent pods doesn't expose an aggregated_privacy_manifest_pod. This blocks the EAS dev client build at the post-install hook. Fixed in RN 0.74.5 (facebook/react-native#45007). Bumping patch version on all three workspaces (mobile, web, root) so npm hoists a single 0.74.5 to root node_modules. Verified: tsc clean on both, next build clean. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Qhile landing the changes for React19 in 0.75, we missed one test that needs to be updated
Changelog:
[Internal] - Fix Jest tests in React 19
Test Plan:
CircleCI is green