Inspector: Add pageId to /json/list, support /open-debugger to a specific page#45138
Closed
robhogan wants to merge 2 commits into
Closed
Inspector: Add pageId to /json/list, support /open-debugger to a specific page#45138robhogan wants to merge 2 commits into
robhogan wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58950622 |
…n-debugger Summary: Previously, if the `/open-debugger` endpoint was provided with both `device` and `appId` query params, we would: - Try to find a target with a matching `device` (note that these logical "devices" are unique per-app) - if found, use it. Otherwise, - Try to find a target with a matching `appId` - if found, use that. This could go "wrong" in two ways: - If a `device` is given with a spurious `appId`, we'd open to a target with an `appId` differing from the one specified. - If the `device` has gone away but there is a different target with the same app, we'd use that as a fallback (right app, wrong device). This applies the filters more strictly so that if both are given, both must match. Changelog: [General][Changed]: Inspector: Enforce device and appId filters if both are given to /open-debugger Differential Revision: D58951952
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58950622 |
robhogan
force-pushed
the
export-D58950622
branch
from
88dbcc5 to
246d1c8
Compare
…ok#45138) Summary: Pull Request resolved: facebook#45138 Add a new `/open-debugger` endpoint format that allows specifying `target` - the proxy-unique target `id`. This is logically equivalent to specifying both device and page. Changelog: [General][Added]: Inspector: Support `/open-debugger` specifying `target` param Differential Revision: D58950622
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58950622 |
robhogan
force-pushed
the
export-D58950622
branch
from
246d1c8 to
54b0361
Compare
Contributor
|
This pull request has been merged in 88ba9a6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
pageIdto thereactNativesection of/json/listinspector proxy responses.pagequery param to/open-debugger, which will use it as a target filter if given.Changelog:
[General][Added]: Inspector: Add pageId to /json/list, support /open-debugger to a specific page
Differential Revision: D58950622