Skip to content

[RN][GHA] Only build_android should write to the Gradle Cache#45160

Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D59002323
Closed

[RN][GHA] Only build_android should write to the Gradle Cache#45160
cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico:export-D59002323

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:
This should optimize the Gradle cache, so that only build_android which
effectively builds everything Android related, should be allowed to write there.

More info on this strategy here:
https://github.com/gradle/actions/blob/main/docs/setup-gradle.md

Changelog:
[Internal] [Changed] - Only build_android should write to the Gradle Cache

Differential Revision: D59002323

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 25, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 25, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,299,706 -21
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,496,914 +1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8bd9952
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@cortinico cortinico changed the title RN][GHA] Only build_android should write to the Gradle Cache [RN][GHA] Only build_android should write to the Gradle Cache Jun 26, 2024
Summary:
Pull Request resolved: facebook#45160

This should optimize the Gradle cache, so that only `build_android` which
effectively builds everything Android related, should be allowed to write there.

More info on this strategy here:
https://github.com/gradle/actions/blob/main/docs/setup-gradle.md

Changelog:
[Internal] [Changed] - Only build_android should write to the Gradle Cache

Reviewed By: cipolleschi

Differential Revision: D59002323
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59002323

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 26, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 88a9b6e.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @cortinico in 88a9b6e.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants