Fix crash on reload when useImmediateExecutorInAndroidBridgeless is enabled#45162
Closed
javache wants to merge 2 commits into
Closed
Fix crash on reload when useImmediateExecutorInAndroidBridgeless is enabled#45162javache wants to merge 2 commits into
javache wants to merge 2 commits into
Conversation
Differential Revision: D59000397
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59002404 |
…nabled (facebook#45162) Summary: Pull Request resolved: facebook#45162 Previously we would crash in ReactInstance#callFunctionOnModule (P1443291303) when reloading (due to the onHostPause call) because we removed a source of synchronization by using the immediate executor. Workaround it by making sure we always null out references to `mReactInstance` before we actually start destroying it. Changelog: [Internal] Differential Revision: D59002404
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59002404 |
javache
force-pushed
the
export-D59002404
branch
from
340a1c7 to
9734bfe
Compare
Base commit: 88ba9a6 |
Contributor
|
This pull request has been merged in c2e0804. |
|
This pull request was successfully merged by @javache in c2e0804. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we would crash in ReactInstance#callFunctionOnModule (P1443291303) when reloading (due to the onHostPause call) because we removed a source of synchronization by using the immediate executor.
Workaround it by making sure we always null out references to
mReactInstancebefore we actually start destroying it.Differential Revision: D59002404