Skip to content

Update codegen artifacts for react-native-test-library #45164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmytrorykun wants to merge 1 commit into from
Closed

Update codegen artifacts for react-native-test-library #45164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...d/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
}

@Override
public void receiveCommand(T view, String commandName, ReadableArray args) {
public void receiveCommand(T view, String commandName, @Nullable ReadableArray args) {
switch (commandName) {
case "changeBackgroundColor":
mViewManager.changeBackgroundColor(view, args.getString(0));
Expand Down
6 changes: 5 additions & 1 deletion ...d/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/OSSLibraryExampleSpecJSI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
: TurboModule(std::string{NativeSampleModuleCxxSpec::kModuleName}, jsInvoker),
delegate_(reinterpret_cast<T*>(this), jsInvoker) {}


private:
class Delegate : public NativeSampleModuleCxxSpecJSI {
public:
Delegate(T *instance, std::shared_ptr<CallInvoker> jsInvoker) :
NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {}
NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {

}

double getRandomNumber(jsi::Runtime &rt) override {
static_assert(
Expand All @@ -54,6 +57,7 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
}

private:
friend class NativeSampleModuleCxxSpec;
T *instance_;
};

Expand Down
5 changes: 0 additions & 5 deletions ...est-library/android/src/main/jni/react/renderer/components/OSSLibraryExampleSpec/States.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

#ifdef ANDROID
#include <folly/dynamic.h>
#include <react/renderer/mapbuffer/MapBuffer.h>
#include <react/renderer/mapbuffer/MapBufferBuilder.h>
#endif

namespace facebook::react {
Expand All @@ -25,9 +23,6 @@ class SampleNativeComponentState {
folly::dynamic getDynamic() const {
return {};
};
MapBuffer getMapBuffer() const {
return MapBufferBuilder::EMPTY();
};
#endif
};

Expand Down
6 changes: 6 additions & 0 deletions packages/react-native-test-library/ios/OSSLibraryExampleSpec/OSSLibraryExampleSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
#ifndef __cplusplus
#error This file must be compiled as Obj-C++. If you are importing it, you must change your file extension to .mm.
#endif

// Avoid multiple includes of OSSLibraryExampleSpec symbols
#ifndef OSSLibraryExampleSpec_H
#define OSSLibraryExampleSpec_H

#import <Foundation/Foundation.h>
#import <RCTRequired/RCTRequired.h>
#import <RCTTypeSafety/RCTConvertHelpers.h>
Expand Down Expand Up @@ -41,3 +46,4 @@ namespace facebook::react {
};
} // namespace facebook::react

#endif // OSSLibraryExampleSpec_H
5 changes: 0 additions & 5 deletions packages/react-native-test-library/ios/OSSLibraryExampleSpec/States.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

#ifdef ANDROID
#include <folly/dynamic.h>
#include <react/renderer/mapbuffer/MapBuffer.h>
#include <react/renderer/mapbuffer/MapBufferBuilder.h>
#endif

namespace facebook::react {
Expand All @@ -25,9 +23,6 @@ class SampleNativeComponentState {
folly::dynamic getDynamic() const {
return {};
};
MapBuffer getMapBuffer() const {
return MapBufferBuilder::EMPTY();
};
#endif
};

Expand Down
6 changes: 5 additions & 1 deletion packages/react-native-test-library/ios/OSSLibraryExampleSpecJSI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,14 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
: TurboModule(std::string{NativeSampleModuleCxxSpec::kModuleName}, jsInvoker),
delegate_(reinterpret_cast<T*>(this), jsInvoker) {}


private:
class Delegate : public NativeSampleModuleCxxSpecJSI {
public:
Delegate(T *instance, std::shared_ptr<CallInvoker> jsInvoker) :
NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {}
NativeSampleModuleCxxSpecJSI(std::move(jsInvoker)), instance_(instance) {

}

double getRandomNumber(jsi::Runtime &rt) override {
static_assert(
Expand All @@ -54,6 +57,7 @@ class JSI_EXPORT NativeSampleModuleCxxSpec : public TurboModule {
}

private:
friend class NativeSampleModuleCxxSpec;
T *instance_;
};

Expand Down