RN: Refactor ScrollView Native Component Imports#45168
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
Summary: Refactors the native component imports in `ScrollView` so that 1) they create less clutter in the `ScrollView` implementation file, and 2) they offer more efficient import inlining. Currently, `ScrollView` has to evaluate both horizontal and vertical components even though only one may be used. Now this optimization is possible. Changelog: [Internal] Differential Revision: D59015990
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59015990 |
Contributor
|
This pull request has been merged in 08b05f3. |
|
This pull request was successfully merged by @yungsters in 08b05f3. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors the native component imports in
ScrollViewso that 1) they create less clutter in theScrollViewimplementation file, and 2) they offer more efficient import inlining.Currently,
ScrollViewhas to evaluate both horizontal and vertical components even though only one may be used. Now this optimization is possible.Changelog: [Internal]
Differential Revision: D59015990