RN: Improvements to LogBoxInspectorHeader#45194
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59081529 |
Base commit: 39b33f1 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59081529 |
yungsters
force-pushed
the
export-D59081529
branch
from
dd50718 to
474588f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59081529 |
yungsters
force-pushed
the
export-D59081529
branch
from
474588f to
152c4a9
Compare
Summary: Pull Request resolved: facebook#45194 Makes a couple improvmeents to `LogBoxInspectorHeader`: - Avoid eagerly initializing the `StatusBar` TurboModule until it is actually needed (which is only when the inspector is rendered on Android). - Switch to `SafeAreaView` on iOS, for more accurate spacing (instead of the hardcoded iPhone X notch size). Changelog: [General][Changed] - Improve LogBox initialization performance [iOS][Changed] - Improve LogBox safe area insets styling Reviewed By: lyahdav Differential Revision: D59081529
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59081529 |
yungsters
force-pushed
the
export-D59081529
branch
from
152c4a9 to
0dff444
Compare
Contributor
|
This pull request has been merged in 1830283. |
|
This pull request was successfully merged by @yungsters in 1830283. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes a couple improvmeents to
LogBoxInspectorHeader:StatusBarTurboModule until it is actually needed (which is only when the inspector is rendered on Android).SafeAreaViewon iOS, for more accurate spacing (instead of the hardcoded iPhone X notch size).Changelog:
[General][Changed] - Improve LogBox initialization performance
[iOS][Changed] - Improve LogBox safe area insets styling
Reviewed By: lyahdav
Differential Revision: D59081529