RN: Fix Test Case Isolation in Modal-test.js#45195
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59097729 |
Base commit: c128a51 |
Summary: Pull Request resolved: facebook#45195 Configure `Modal-test.js` to reset modules between test cases so that there is better isolation, making the tests easier to reason about and to debug. Changelog: [Internal] Differential Revision: D59097729
yungsters
force-pushed
the
export-D59097729
branch
from
4a56d21 to
351fa85
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59097729 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 27, 2024
Summary: Pull Request resolved: facebook#45195 Configure `Modal-test.js` to reset modules between test cases so that there is better isolation, making the tests easier to reason about and to debug. Changelog: [Internal] Differential Revision: D59097729
Contributor
|
This pull request has been merged in 3965b7d. |
|
This pull request was successfully merged by @yungsters in 3965b7d. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Configure
Modal-test.jsto reset modules between test cases so that there is better isolation, making the tests easier to reason about and to debug.Changelog:
[Internal]
Differential Revision: D59097729