Skip to content

Expose preprocessor flag/Buck constraint for Fusebox opt in #45203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Expose preprocessor flag/Buck constraint for Fusebox opt in #45203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ InspectorFlags& InspectorFlags::getInstance() {
}

bool InspectorFlags::getFuseboxEnabled() const {
return loadFlagsAndAssertUnchanged().fuseboxEnabledDebug;
return loadFlagsAndAssertUnchanged().fuseboxEnabled;
}

void InspectorFlags::dangerouslyResetFlags() {
Expand All @@ -28,11 +28,15 @@ void InspectorFlags::dangerouslyResetFlags() {
const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
const {
InspectorFlags::Values newValues = {
.fuseboxEnabledDebug =
.fuseboxEnabled =
#ifdef REACT_NATIVE_FORCE_ENABLE_FUSEBOX
true,
#elif defined(HERMES_ENABLE_DEBUGGER)
#ifdef REACT_NATIVE_ENABLE_FUSEBOX_DEBUG
true,
#else
ReactNativeFeatureFlags::fuseboxEnabledDebug(),
#endif
#else
ReactNativeFeatureFlags::fuseboxEnabledRelease(),
#endif
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class InspectorFlags {

private:
struct Values {
bool fuseboxEnabledDebug;
bool fuseboxEnabled;
bool operator==(const Values&) const = default;
};

Expand Down