Skip to content

Merge newarchdefaults jni target into fabric and turbomodule targets#45207

Closed
javache wants to merge 2 commits into
facebook:mainfrom
javache:export-D59107105
Closed

Merge newarchdefaults jni target into fabric and turbomodule targets#45207
javache wants to merge 2 commits into
facebook:mainfrom
javache:export-D59107105

Conversation

@javache
Copy link
Copy Markdown
Member

@javache javache commented Jun 27, 2024

Summary:
These are their own shared library, and their own soloader-call, but they can easily be pulled into existing targets without causing excessive bloat.

Changelog: [Android][Removed] react_newarchdefaults is no longer a prefab, instead use fabricjni

Differential Revision: D59107105

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 27, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from d1cc1e9 to 2ecfb03 Compare June 28, 2024 08:39
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from 2ecfb03 to c1efdcd Compare June 28, 2024 12:37
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from c1efdcd to 9560e29 Compare June 28, 2024 13:08
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from 9560e29 to 95fd1c2 Compare June 28, 2024 13:26
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from 95fd1c2 to ceb88dc Compare June 28, 2024 13:32
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from ceb88dc to cf844bd Compare June 28, 2024 14:08
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from cf844bd to 50f3c38 Compare June 28, 2024 15:19
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from 50f3c38 to 842eb6a Compare June 28, 2024 16:35
@javache javache force-pushed the export-D59107105 branch from 842eb6a to 5c89fa8 Compare July 1, 2024 09:39
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 1, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,202,062 -164,042
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,398,866 -164,042
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c7988c9
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from 5c89fa8 to ffcd1d0 Compare July 1, 2024 10:30
…acebook#45207)

Summary:
Pull Request resolved: facebook#45207

These are their own shared library, and their own soloader-call, but they can easily be pulled into existing targets without causing excessive bloat.

Changelog: [Android][Removed] react_newarchdefaults is no longer a prefab, instead use fabricjni

Reviewed By: christophpurrer

Differential Revision: D59107105
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59107105

@javache javache force-pushed the export-D59107105 branch from ffcd1d0 to 15c48ed Compare July 1, 2024 10:42
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 1, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in c68f35d.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2024

This pull request was successfully merged by @javache in c68f35d.

When will my fix make it into a release? | How to file a pick request?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been reverted by 9d30523.

@javache javache deleted the export-D59107105 branch July 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants