do not call [super loadView] in RN's UIViewController#45312
Closed
sammy-SC wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59376105 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59376105 |
sammy-SC
force-pushed
the
export-D59376105
branch
from
214fcdf to
1a1ecfa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59376105 |
sammy-SC
force-pushed
the
export-D59376105
branch
from
1a1ecfa to
a2412bb
Compare
Summary: Pull Request resolved: facebook#45312 changelog: [internal] loadview shouldn't call its super method. Even though it isn't broken now, the official docs recommend against it. https://developer.apple.com/documentation/uikit/uiviewcontroller/1621454-loadview Reviewed By: christophpurrer Differential Revision: D59376105
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59376105 |
sammy-SC
force-pushed
the
export-D59376105
branch
from
a2412bb to
9a5daae
Compare
Contributor
|
This pull request has been merged in 83392a9. |
|
This pull request was successfully merged by @sammy-SC in 83392a9. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
loadview shouldn't call its super method. Even though it isn't broken now, the official docs recommend against it.
https://developer.apple.com/documentation/uikit/uiviewcontroller/1621454-loadview
Reviewed By: christophpurrer
Differential Revision: D59376105