Simplify Java TurboModule lookup#45322
Closed
javache wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59465976 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59465976 |
Base commit: 12b64b7 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59465976 |
Summary: Pull Request resolved: facebook#45322 Instead of using multiple weak_ptr and weak_ref, use a single weak_ref to the Java object and use that to get back to the original C++ instance, without the need for additional shared_ptr. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D59465976
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59465976 |
javache
force-pushed
the
export-D59465976
branch
from
4a32db2 to
36ac040
Compare
Contributor
|
This pull request has been merged in 2455a84. |
|
This pull request was successfully merged by @javache in 2455a84. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of using multiple weak_ptr and weak_ref, use a single weak_ref to the Java object and use that to get back to the original C++ instance, without the need for additional shared_ptr.
Changelog: [Internal]
Differential Revision: D59465976