Do eager native module init concurrently with JS bundle loading#45324
Closed
javache wants to merge 5 commits into
Closed
Do eager native module init concurrently with JS bundle loading#45324javache wants to merge 5 commits into
javache wants to merge 5 commits into
Conversation
Differential Revision: D59465975
Differential Revision: D59465978
Differential Revision: D59465974
Differential Revision: D59465976
Summary: Some native modules can be expensive to initialize (eg ones that do Android IPC). Since we have sufficient concurrency controls in the TurboModule lookup path, we can do this eager init on the native modules thread, and bring forward JS bundle execution. Changelog: [Android][Changed] TurboModules that set `needsEagerInit = true` will now be constructed on the mqt_native thread. Differential Revision: D59465977
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59465977 |
Contributor
|
This pull request has been merged in c4a6bbc. |
|
This pull request was successfully merged by @javache in c4a6bbc. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some native modules can be expensive to initialize (eg ones that do Android IPC). Since we have sufficient concurrency controls in the TurboModule lookup path, we can do this eager init on the native modules thread, and bring forward JS bundle execution.
Changelog: [Android][Changed] TurboModules that set
needsEagerInit = truewill now be constructed on the mqt_native thread.Differential Revision: D59465977