Move assertion about invalidated ReactInstanceManager to UI thread#45328
Closed
javache wants to merge 1 commit into
Closed
Move assertion about invalidated ReactInstanceManager to UI thread#45328javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: This assertion is currently not actionable since the stack trace will always be just `mCreateReactContextThread`. Moving this assert is safe, as the only other place we write it is also the UI thread. Changelog: [Internal] Differential Revision: D59467576
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59467576 |
Contributor
|
This pull request has been merged in 6b7076e. |
|
This pull request was successfully merged by @javache in 6b7076e. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This assertion is currently not actionable since the stack trace will always be just
mCreateReactContextThread. Moving this assert is safe, as the only other place we write it is also the UI thread.Changelog: [Internal]
Differential Revision: D59467576