Send onScrollEnded Event to native driver#45382
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
Base commit: c1b4133 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
3a18147 to
cd47417
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
cd47417 to
b5a4692
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
b5a4692 to
6ed884a
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: facebook#45382 This change is the first step to tr and solve the pressability's `onTouchMove` issue with animation driven natively in the New Architecture. The idea is to trigger a special event from native to let JS know that a scroll event has ended (`scrollViewDidEndDragging` or `scrollViewdidEndDecelerating`). When this happens, we need to send an event to JS to let him know that it has to sync the Native Tree with the Shadow Tree. Step 2 is to connect Native with JS ## Changelog: [iOS][Added] - Send onScrollEnded event to NativeTurboAnimatedModule Differential Revision: D59459989 Reviewed By: sammy-SC
cipolleschi
force-pushed
the
export-D59459989
branch
from
6ed884a to
ab87d4b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
ab87d4b to
395b1c5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
395b1c5 to
1190fd0
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45382 This change is the first step to tr and solve the pressability's `onTouchMove` issue with animation driven natively in the New Architecture. The idea is to trigger a special event from native to let JS know that a scroll event has ended (`scrollViewDidEndDragging` or `scrollViewdidEndDecelerating`). When this happens, we need to send an event to JS to let him know that it has to sync the Native Tree with the Shadow Tree. Step 2 is to connect Native with JS ## Changelog: [iOS][Added] - Send onScrollEnded event to NativeTurboAnimatedModule Differential Revision: D59459989 Reviewed By: sammy-SC
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
1190fd0 to
794d7d5
Compare
Summary: Pull Request resolved: facebook#45382 This change is the first step to tr and solve the pressability's `onTouchMove` issue with animation driven natively in the New Architecture. The idea is to trigger a special event from native to let JS know that a scroll event has ended (`scrollViewDidEndDragging` or `scrollViewdidEndDecelerating`). When this happens, we need to send an event to JS to let him know that it has to sync the Native Tree with the Shadow Tree. Step 2 is to connect Native with JS ## Changelog: [iOS][Added] - Send onScrollEnded event to NativeTurboAnimatedModule Reviewed By: sammy-SC Differential Revision: D59459989
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59459989 |
cipolleschi
force-pushed
the
export-D59459989
branch
from
794d7d5 to
22473e5
Compare
Contributor
|
This pull request has been merged in 7af7432. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 7af7432 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change is the first step to tr and solve the pressability's
onTouchMoveissue with animation driven natively in the New Architecture.The idea is to trigger a special event from native to let JS know that a scroll event has ended (
scrollViewDidEndDraggingorscrollViewdidEndDecelerating).When this happens, we need to send an event to JS to let him know that it has to sync the Native Tree with the Shadow Tree.
Step 2 is to connect Native with JS
Changelog:
[iOS][Added] - Send onScrollEnded event to NativeTurboAnimatedModule
Differential Revision: D59459989