Undo a breaking change with I18nUtil.instance#45390
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
Summary: This undos a breaking change we're about to ship in 0.75, where Kotlin users where forced to update this callsite to be `.getEntryIterator`. This re-introduces a `entryIterator` val so both Kotlin and Java compatibility are retained. Changelog: [Android] [Fixed] - Undo breaking change for ReadableMap.entryIterator for Kotlin consumers Differential Revision: D59637925
Summary: This undos a breaking change with I18nUtil for Kotlin consumer. I've re-added a `getInstance` method so that Kotlin libraries won't break. The method is added as Deprecated as those libraries need to migrate to `.instance` accessors as more idiomatic. Changelog: [Android] [Fixed] - Undo a breaking change with I18nUtil.instance Differential Revision: D59638044
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59638044 |
| * | ||
| * @deprecated Use instance instead | ||
| */ | ||
| @Deprecated("Use instance .instead, this is ", ReplaceWith("instance")) |
Collaborator
There was a problem hiding this comment.
Suggested change
| @Deprecated("Use instance .instead, this is ", ReplaceWith("instance")) | |
| @Deprecated("Use .instance instead, this is ", ReplaceWith("instance")) |
Contributor
|
This pull request has been merged in 221755c. |
blakef
pushed a commit
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: #45390 This undos a breaking change with I18nUtil for Kotlin consumer. I've re-added a `getInstance` method so that Kotlin libraries won't break. The method is added as Deprecated as those libraries need to migrate to `.instance` accessors as more idiomatic. Changelog: [Android] [Fixed] - Undo a breaking change with I18nUtil.instance Reviewed By: alanleedev Differential Revision: D59638044 fbshipit-source-id: 1c93a98676b5b01e89be3b974961c5f3ae919511
This was referenced Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This undos a breaking change with I18nUtil for Kotlin consumer.
I've re-added a
getInstancemethod so that Kotlin libraries won't break.The method is added as Deprecated as those libraries need to migrate to
.instanceaccessors as more idiomatic.
Changelog:
[Android] [Fixed] - Undo a breaking change with I18nUtil.instance
Differential Revision: D59638044