Skip to content

Introduce Systrace.beginSection with args #45392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 1 commit into from
Closed

Introduce Systrace.beginSection with args #45392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/systrace/Systrace.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
package com.facebook.systrace

import androidx.tracing.Trace
import kotlin.text.StringBuilder

/**
* Systrace stub that mostly does nothing but delegates to Trace for beginning/ending sections. The
Expand Down Expand Up @@ -35,6 +36,28 @@ public object Systrace {
Trace.beginSection(sectionName)
}

@JvmStatic
public fun beginSection(tag: Long, sectionName: String, args: Array<String>, argsLength: Int) {
Trace.beginSection(sectionName + "|" + convertArgsToText(args, argsLength))
}

private fun convertArgsToText(args: Array<String>, argsLength: Int): String {
val argsText: StringBuilder = StringBuilder()
var ii = 1
while (ii < argsLength) {
val key = args[ii - 1]
val value = args[ii]
argsText.append(key)
argsText.append('=')
argsText.append(value)
if (ii < argsLength - 1) {
argsText.append(';')
}
ii += 2
}
return argsText.toString()
}

@JvmStatic
public fun endSection(tag: Long) {
Trace.endSection()
Expand Down