Skip to content

Reland: [iOS] Fixes ellipsis carries background from trimmed text#45412

Closed
zhongwuzw wants to merge 1 commit into
facebook:mainfrom
zhongwuzw:features/fix_ellipsis_background_2
Closed

Reland: [iOS] Fixes ellipsis carries background from trimmed text#45412
zhongwuzw wants to merge 1 commit into
facebook:mainfrom
zhongwuzw:features/fix_ellipsis_background_2

Conversation

@zhongwuzw
Copy link
Copy Markdown
Contributor

Summary:

Reland #39408 . Try to fix the crash #37926 (comment). cc. @javache I changed the range from glyph to character because all attributes related APIs are character range.

Changelog:

[IOS] [FIXED] - Fixes ellipsis carries background from trimmed text

Test Plan:

#37926 .

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 12, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,267,872 +16
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,464,995 +21
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 47261bf
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache merged this pull request in 9e2f885.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 15, 2024
@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @zhongwuzw in 9e2f885

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants