Check nullability of native view config before validation#45420
Closed
Abbondanzo wants to merge 1 commit into
Closed
Check nullability of native view config before validation#45420Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59702501 |
…5420) Summary: Pull Request resolved: facebook#45420 Devex improvement to skip validation when no native view config exists. Redbox is still hit, showing the true error. See test plan below before/after Changelog: [Internal] Differential Revision: D59702501
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59702501 |
Abbondanzo
force-pushed
the
export-D59702501
branch
from
35d9dd6 to
a83e535
Compare
Contributor
|
This pull request has been merged in 1ca63e3. |
|
This pull request was successfully merged by Peter Abbondanzo in 1ca63e3. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Devex improvement to skip validation when no native view config exists. Redbox is still hit, showing the true error. See test plan below before/after
Changelog: [Internal]
Differential Revision: D59702501