jsinspector: Fix various build warnings#45423
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59693730 |
Summary: Pull Request resolved: #45423 I noticed while fixing some CI issues that `jsinspector` emits a bunch of warnings, making finding errors (especially in CI logs) awkward. Also fix up a couple of stale comments from earlier designs of `NetworkIOAgent`. Changelog: [Internal] Differential Revision: D59693730
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59693730 |
robhogan
force-pushed
the
export-D59693730
branch
from
c76252c to
f2f2a5b
Compare
|
This pull request was successfully merged by @robhogan in f2f2a5b. When will my fix make it into a release? | How to file a pick request? |
Base commit: 65a3259 |
|
This pull request was successfully merged by @robhogan in 3c7e307. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I noticed while fixing some CI issues that
jsinspectoremits a bunch of warnings, making finding errors (especially in CI logs) awkward.Also fix up a couple of stale comments from earlier designs of
NetworkIOAgent.Changelog: [Internal]
Differential Revision: D59693730