Remove sampling profiler from dev menu#45431
Closed
blakef wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59686976 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59686976 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59686976 |
Summary: Pull Request resolved: #45431 This build samples using the legacy format, that have to be manually downloaded and translated by the [removed](react-native-community/cli@aca901d) `npx react-native-community/cli profile-hermes` command. Changelog: [Internal][Removed] Profiler option in Catalyst's (Bridge) dev menu Reviewed By: cortinico Differential Revision: D59686976
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59686976 |
Contributor
|
This pull request has been merged in f57740c. |
|
This pull request was successfully merged by @blakef in f57740c. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This build samples using the legacy format, that have to be manually downloaded and translated by the removed
npx react-native-community/cli profile-hermescommand.Changelog: [Internal][Removed] Profiler option in Catalyst's (Bridge) dev menu
Differential Revision: D59686976