JS plumbing to get boxShadow into native#45452
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57872933 |
Base commit: 0ad4373 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57872933 |
NickGerleman
force-pushed
the
export-D57872933
branch
from
355b6f8 to
88f254d
Compare
Summary: Pull Request resolved: facebook#45452 With this we enable <View> to use BoxShadow. BoxShadow property can be a string as defined on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow Or it can also be a list of BoxShadow primitives: ``` [ { offsetX: 10, offsetY: 5, color: 'red', inset: true, }, { ... }, ] ``` The diff includes: * Style sheet changes so typing is valid * Process function to turn boxShadow format into parsed boxShadow primitive * Test for process function * View config changes on Android, iOS and ReactNativeStyleAttributes Changelog: [Internal] Reviewed By: joevilches Differential Revision: D57872933
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57872933 |
NickGerleman
force-pushed
the
export-D57872933
branch
from
88f254d to
1408331
Compare
Contributor
|
This pull request has been merged in 27c6fcb. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 27c6fcb When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With this we enable to use BoxShadow.
BoxShadow property can be a string as defined on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
Or it can also be a list of BoxShadow primitives:
The diff includes:
Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D57872933