Use weak ptr for runtime shadow node reference#45463
Closed
lenaic wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59804999 |
Base commit: 5bb57eb |
Summary: Pull Request resolved: facebook#45463 Changelog: [Internal] State updates will clone shadow nodes for an shadow tree revision that is outdated. This can lead to accessing deallocated shadow node references because the JS renderer committed a newer revision and deallocated the one used by the pending state update. By using a weak pointer to hold a reference to the runtime shadow node reference, we can only update references for wrappers that are still valid. Differential Revision: D59804999
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59804999 |
Contributor
|
This pull request has been merged in c0b288c. |
|
This pull request was successfully merged by Nick Lefever in c0b288c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
State updates will clone shadow nodes for an shadow tree revision that is outdated.
This can lead to accessing deallocated shadow node references because the JS renderer committed a newer revision and deallocated the one used by the pending state update.
By using a weak pointer to hold a reference to the runtime shadow node reference, we can only update references for wrappers that are still valid.
Differential Revision: D59804999