Add support for longer tasks with explicit yielding in LongTask API#45471
Add support for longer tasks with explicit yielding in LongTask API#45471rubennorte wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
Base commit: c82edec |
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
3f29182 to
08baed4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
08baed4 to
c19aaf2
Compare
rubennorte
force-pushed
the
export-D55647992
branch
from
c19aaf2 to
a427995
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
a427995 to
74c63cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
74c63cf to
babdee3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
babdee3 to
149a1cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
149a1cf to
4f3c77d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
4f3c77d to
55cdb30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
55cdb30 to
8224c05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
8224c05 to
ce82e65
Compare
Differential Revision: D59820241
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
force-pushed
the
export-D55647992
branch
from
ce82e65 to
a5ceb67
Compare
Differential Revision: D55491870
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
rubennorte
force-pushed
the
export-D55647992
branch
from
a5ceb67 to
ce4145e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
|
This pull request has been merged in 15b8ac8. |
3 participants
Summary:
Changelog: [internal]
This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks.
In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long".
Check the new unit tests to see this behavior in practice.
Differential Revision: D55647992