Remove _shouldEmitEvent guardrails#45476
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
Base commit: dbbb406 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
cipolleschi
force-pushed
the
export-D59811656
branch
from
934cec5 to
7e8e903
Compare
cipolleschi
force-pushed
the
export-D59811656
branch
from
7e8e903 to
740c75d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
cipolleschi
force-pushed
the
export-D59811656
branch
from
740c75d to
8a17143
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
cipolleschi
force-pushed
the
export-D59811656
branch
from
8a17143 to
1f17df8
Compare
Summary: Pull Request resolved: facebook#45414 This change completes the fix for broken pressable when animations were applied to components with native driven animations. When creating the AnimatedProps, if they are natively drive animation, we look for the AnimatedValue involved and we register a listener. This is needed to make sure that the NativeModule will send te updated value upon calling the `update` function. Then, when observing the props lifecycle, it register a listener to the new `OnUserAnimationEnded` event, fired by the NativeAnimation module. When the `OnUserAnimationEnded` event is fired, the AnimatedProps will update the props that depends on the user driven animation. ## Changelog [General][Fixed] - reallign the shadow tree and the native tree when the user finishes interacting with the app. Differential Revision: D59681428
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59811656 |
cipolleschi
force-pushed
the
export-D59811656
branch
from
1f17df8 to
79cca30
Compare
Contributor
|
This pull request has been merged in dae9c5c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Land this after #45457 lands.
After #45457 there is no need to check for listeners to the native event as we will have those listeners for sure.
Changelog
[Internal] - Remove
_shouldEmitEventguardrails as we always have listenersDifferential Revision: D59811656