Skip to content

Rename "spreadRadius" -> "spreadDistance"#45481

Closed
joevilches wants to merge 1 commit into
facebook:mainfrom
joevilches:export-D59819180
Closed

Rename "spreadRadius" -> "spreadDistance"#45481
joevilches wants to merge 1 commit into
facebook:mainfrom
joevilches:export-D59819180

Conversation

@joevilches
Copy link
Copy Markdown
Contributor

Summary:
We are going with this name as it is more commonly used in the spec and makes more sense since there are no circles involved with spread

Changelog: [Internal]

Differential Revision: D59819180

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 16, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59819180

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59819180

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 16, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,353,376 -225
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,549,515 +65
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 394aae1
Branch: main

Summary:
Pull Request resolved: facebook#45481

We are going with this name as it is more commonly used in the spec and makes more sense since there are no circles involved with spread

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D59819180
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59819180

joevilches added a commit to joevilches/react-native that referenced this pull request Jul 17, 2024
Summary:
Pull Request resolved: facebook#45481

We are going with this name as it is more commonly used in the spec and makes more sense since there are no circles involved with spread

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D59819180
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 18, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 1e20e49.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @joevilches in 1e20e49

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants