FilterPrimitive -> FilterFunction#45505
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
Summary: Kebab case object literals are a pain as an API to give folks. Keep string parsing using the kebab-case web names, like in CSS, but keep object notation camelCase. This is super super hacked up, and we should burn away all these viewconfig processors as soon as we can. Changelog: [Internal] Differential Revision: D59793095
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59793167 |
Summary: Pull Request resolved: facebook#45505 These are filter functions, not primitives. Change the name to be more accurate and easier to understand. https://drafts.fxtf.org/filter-effects/#filter-functions changelog: [internal] Differential Revision: D59793167
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59793167 |
NickGerleman
force-pushed
the
export-D59793167
branch
from
a0ad6e5 to
fa7b578
Compare
Base commit: 17cbe7d |
Contributor
|
This pull request has been merged in c82edec. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in c82edec When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These are filter functions, not primitives. Change the name to be more accurate and easier to understand.
https://drafts.fxtf.org/filter-effects/#filter-functions
changelog: [internal]
Differential Revision: D59793167