Skip to content

Fix data race in BufferedRuntimeExecutor#45512

Closed
lexs wants to merge 1 commit into
facebook:mainfrom
lexs:export-D59907026
Closed

Fix data race in BufferedRuntimeExecutor#45512
lexs wants to merge 1 commit into
facebook:mainfrom
lexs:export-D59907026

Conversation

@lexs
Copy link
Copy Markdown
Contributor

@lexs lexs commented Jul 18, 2024

Summary:
isBufferingEnabled_ can be read (by design) from multiple threads, but
it's not atomic. Make it so.

Differential Revision: D59907026

Summary:
isBufferingEnabled_ can be read (by design) from multiple threads, but
it's not atomic. Make it so.

Differential Revision: D59907026
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 18, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D59907026

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,354,853 +22
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,549,989 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c82edec
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 18, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in a37534e.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Alexander Blom in a37534e

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants