Restrict durationThreshold to event entry types only#45524
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59918519 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59918519 |
rubennorte
force-pushed
the
export-D59918519
branch
from
de610bd to
7fab06c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59918519 |
rubennorte
force-pushed
the
export-D59918519
branch
from
7fab06c to
fcaa798
Compare
Summary: Pull Request resolved: facebook#45524 Changelog: [internal] The `durationThreshold` option is only meant to be used with `event` entry types. `mark`, `measure`, `longtask`, etc. shouldn't take that option into account, as per the spec. Reviewed By: mdvacca Differential Revision: D59918519
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59918519 |
rubennorte
force-pushed
the
export-D59918519
branch
from
fcaa798 to
10f3b7b
Compare
Contributor
|
This pull request has been merged in 9b06ac8. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 9b06ac8 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The
durationThresholdoption is only meant to be used withevententry types.mark,measure,longtask, etc. shouldn't take that option into account, as per the spec.Differential Revision: D59918519