Remove experimental_boxShadow from Android base view config#45529
Closed
NickGerleman wants to merge 1 commit into
Closed
Remove experimental_boxShadow from Android base view config#45529NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Summary: `experimental_boxShadow` is not yet part of Android view managers, and when we enable it, we are likely to do a view manager at a time before moving to BaseViewManager. This causes user-visible errors when viewconfig validation is turned on, since we have a static view config, but not yet a native view config. This removes the static viewconfig for Android until we start adding setters to view manager. It is kept in `ReactNativeStyleAttributes` (which I think can have members not in the native view-config, since it has component specific props like tintColor), and iOS base viewconfig. On Fabric iOS, this is part of BaseViewProps, and handled by RCTView, but it looks like the prop (and also `experimental_filter`, `experimental_mixBlendMode`) do not have entries in iOS RCTViewManager, which is fixed in next diff in the stack. Differential Revision: D59939866
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59939866 |
Contributor
|
This pull request has been merged in 245e5d9. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 245e5d9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
experimental_boxShadowis not yet part of Android view managers, and when we enable it, we are likely to do a view manager at a time before moving to BaseViewManager.This causes user-visible errors when viewconfig validation is turned on, since we have a static view config, but not yet a native view config.
This removes the static viewconfig for Android until we start adding setters to view manager.
It is kept in
ReactNativeStyleAttributes(which I think can have members not in the native view-config, since it has component specific props like tintColor), and iOS base viewconfig. On Fabric iOS, this is part of BaseViewProps, and handled by RCTView, but it looks like the prop (and alsoexperimental_filter,experimental_mixBlendMode) do not have entries in iOS RCTViewManager, which is fixed in next diff in the stack.Differential Revision: D59939866