Expose PerformanceObserver related classes in the global scope#45539
Closed
rubennorte wants to merge 5 commits into
Closed
Expose PerformanceObserver related classes in the global scope#45539rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59859654 |
Differential Revision: D59918519
Differential Revision: D59911145
Differential Revision: D59911144
…isting convention Differential Revision: D59911334
…ook#45539) Summary: Pull Request resolved: facebook#45539 Changelog: [internal] This exposes several classes (interfaces in the spec lingo) related to the Performance API to the global scope, so users can access them directly to do things like refinements using `instanceof`. This also prevents the need from importing the modules from `react-native` directly, which would prevent code sharing with Web. Reviewed By: rshest Differential Revision: D59859654
rubennorte
force-pushed
the
export-D59859654
branch
from
210a6d2 to
0f17da0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59859654 |
Contributor
|
This pull request has been merged in 2551aee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This exposes several classes (interfaces in the spec lingo) related to the Performance API to the global scope, so users can access them directly to do things like refinements using
instanceof. This also prevents the need from importing the modules fromreact-nativedirectly, which would prevent code sharing with Web.Reviewed By: rshest
Differential Revision: D59859654