fix ConcurrentModificationException in ReactScrollViewHelper#45550
Closed
alanleedev wants to merge 1 commit into
Closed
fix ConcurrentModificationException in ReactScrollViewHelper#45550alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59991739 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59991739 |
alanleedev
force-pushed
the
export-D59991739
branch
from
e64cf66 to
929fb17
Compare
…k#45550) Summary: Pull Request resolved: facebook#45550 `ConcurrentModificationException` is happening from `emitScrollEvent()`. This usually happens if we modify the collection (add/remove) while accessing collection in a foreach loop. Seems likely add/remove is called from a different thread while in the foreach loop. Converting to list before we do the foreach as a quick fix. Changelog: [Internal] - quick fix for exception Issure reported here: https://fb.workplace.com/groups/rn.support/permalink/26557068097248454/ Reviewed By: mdvacca Differential Revision: D59991739
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59991739 |
alanleedev
force-pushed
the
export-D59991739
branch
from
929fb17 to
743eea1
Compare
Contributor
|
This pull request has been merged in 3a5eb19. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 3a5eb19 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ConcurrentModificationExceptionis happening fromemitScrollEvent().This usually happens if we modify the collection (add/remove) while accessing collection in a foreach loop.
Seems likely add/remove is called from a different thread while in the foreach loop.
Converting to list before we do the foreach as a quick fix.
Changelog: [Internal] - quick fix for exception
Reviewed By: mdvacca
Differential Revision: D59991739