Fix core autolinking not working on Windows#45572
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Fix core autolinking not working on Windows#45572cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: 0.75-rc.5 is currently broken on Windows. This is due to us invoking `npx react-native-community/cli config` without a `cmd /c` prefix. This fixes it by using our function `windowsAwareCommandLine`. The problem is that this required a lot of refactoring since that util was not available for the settings plugin. Fixes facebook#45403 Changelog: [Internal] [Changed] - Fix core autolinking not working on Windows Differential Revision: D60037587
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60037587 |
Contributor
|
This pull request has been merged in fedbe2d. |
Collaborator
|
This pull request was successfully merged by @cortinico in fedbe2d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
0.75-rc.5 is currently broken on Windows.
This is due to us invoking
npx react-native-community/cli configwithouta
cmd /cprefix.This fixes it by using our function
windowsAwareCommandLine.The problem is that this required a lot of refactoring since that util was not available for the settings plugin.
Fixes #45403
Changelog:
[Internal] [Changed] - Fix core autolinking not working on Windows
Differential Revision: D60037587