Use NativeHostTargetSessionObserver in LogBox#45578
Closed
hoxyq wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59975265 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59975265 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59975265 |
Summary: Pull Request resolved: facebook#45577 # Changelog: [Internal] This diff adds new native module, which can be used from JavaScript. The API includes: 1. `hasActiveSession`: returns a boolean flag, which can be used for determining if 1 or more debugging sessions are active for current HostTarget. 2. `subscribe`: receives a callback, which will be executed once the debugging state changes. To be more precise, this will only be called when state is changing from no active sessions to 1 session or the other way around. Callback should expect to receive one boolean argument, which can be used for determining if there is an active session. Differential Revision: D59975264
Summary: Pull Request resolved: facebook#45578 # Changelog: [Internal] Use previously introduced native module for managing the presence of warning notifications in LogBox: - Don't display warnings and Fusebox migration message if there is an active debugging session - If the session has just been started, clear warnings to hide Fusebox migration message - If there is no active debugging session (even if there were some at some point of Host lifetime), display Fusebox migration message See demo in test plan. Reviewed By: huntie Differential Revision: D59975265
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59975265 |
Contributor
|
This pull request has been merged in 9c61d9a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Use previously introduced native module for managing the presence of warning notifications in LogBox:
See demo in test plan.
Differential Revision: D59975265