chore: tests migration to assertj (KotlinStdlibCompatUtilsTest, ModelAutolinkingDependenciesJsonTest, PathUtilsTest, DependencyUtilsTest, ProjectUtilsTest)#45606
Conversation
|
Hi @kachmashk! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hey @cortinico, cannot add you as a reviewer so @ you here. |
cortinico
left a comment
There was a problem hiding this comment.
Can you invert the equal assertion so that is:
assertThat(actual).isEqualTo(expected)
You have this in several tests
cortinico
left a comment
There was a problem hiding this comment.
Can you invert the equal assertion so that is:
assertThat(actual).isEqualTo(expected)
You have this in several tests
Made a mistake by not checking |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @cortinico, how could I fix the |
I fixed it for you. The status doesn't update automatically, but the final commit that will land will be properly formatted 👍 |
|
@cortinico merged this pull request in 4cc46e3. |
|
This pull request was successfully merged by @kachmashk in 4cc46e3 When will my fix make it into a release? | How to file a pick request? |
Summary:
#45596
Changelog:
Migrated to AssertJ within files:
KotlinStdlibCompatUtilsTest.kt,ModelAutolinkingDependenciesJsonTest.kt,PathUtilsTest.kt,DependencyUtilsTest.kt,ProjectUtilsTest.kt.[INTERNAL] [CHANGED] - Migrated
KotlinStdlibCompatUtilsTest,ModelAutolinkingDependenciesJsonTest,PathUtilsTest,DependencyUtilsTest,ProjectUtilsTestfromjunit.Asserttoassertj.core.api.Assertions.Test Plan