Skip to content

[RNGP] chore: ☂️ migrate BackwardCompatUtilsTest to AssertJ#45607

Closed
gustavoabel wants to merge 1 commit into
facebook:mainfrom
gustavoabel:chore/migrate-BackwardCompatUtilsTest-to-AssertJ
Closed

[RNGP] chore: ☂️ migrate BackwardCompatUtilsTest to AssertJ#45607
gustavoabel wants to merge 1 commit into
facebook:mainfrom
gustavoabel:chore/migrate-BackwardCompatUtilsTest-to-AssertJ

Conversation

@gustavoabel
Copy link
Copy Markdown
Contributor

@gustavoabel gustavoabel commented Jul 23, 2024

Summary:

Issue: #45596

Changelog:

Migrated to AssertJ within file:

  • BackwardCompatUtilsTest.kt

[Android] [Changed] - Migrated BackwardCompatUtilsTest

Test Plan:

Run ./gradlew -p packages/gradle-plugin test

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @gustavoabel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@gustavoabel
Copy link
Copy Markdown
Contributor Author

gustavoabel commented Jul 23, 2024

hey @cortinico, it's done.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 23, 2024
@gustavoabel gustavoabel changed the title chore: migrate BackwardCompatUtilsTest to AssertJ [RNGP] chore: migrate BackwardCompatUtilsTest to AssertJ Jul 23, 2024
@gustavoabel gustavoabel changed the title [RNGP] chore: migrate BackwardCompatUtilsTest to AssertJ [RNGP] chore: ☂️ migrate BackwardCompatUtilsTest to AssertJ Jul 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 24, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 7829de6.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gustavoabel in 7829de6

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants