Skip to content

[RNGP] feat: migrate JsonUtilsTest, OsTest and TaskUtilsTest to AssertJ#45608

Closed
migueldaipre wants to merge 3 commits into
facebook:mainfrom
migueldaipre:feat/migrate-tests-asserts-to-assertj
Closed

[RNGP] feat: migrate JsonUtilsTest, OsTest and TaskUtilsTest to AssertJ#45608
migueldaipre wants to merge 3 commits into
facebook:mainfrom
migueldaipre:feat/migrate-tests-asserts-to-assertj

Conversation

@migueldaipre
Copy link
Copy Markdown
Collaborator

@migueldaipre migueldaipre commented Jul 23, 2024

Summary:

Issue: #45596

Note:

The formatting changes have been altered by Android Studio. Code -> Format Code

Changelog:

[ANDROID] [CHANGED] - Migrated JsonUtilsTest, OsTest, TaskUtilsTest from junit.Assert to assertj.core.api.Assertions.

Test Plan:

Run ./gradlew -p packages/gradle-plugin test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2024
@migueldaipre
Copy link
Copy Markdown
Collaborator Author

Hey @cortinico. Done

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 23, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in e7881c2.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 24, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @migueldaipre in e7881c2

When will my fix make it into a release? | How to file a pick request?

@migueldaipre migueldaipre deleted the feat/migrate-tests-asserts-to-assertj branch September 10, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants