Refactor: RuntimeScheduler: Make error handlers configurable#45616
Closed
RSNara wants to merge 1 commit into
Closed
Refactor: RuntimeScheduler: Make error handlers configurable#45616RSNara wants to merge 1 commit into
RSNara wants to merge 1 commit into
Conversation
Summary: We want to eventually route all js error handling through JsErrorHandler in bridgeless. This will help with that. Changelog: [Internal] Differential Revision: D60138415
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60138415 |
Contributor
|
This pull request has been merged in 842c382. |
Collaborator
|
This pull request was successfully merged by @RSNara in 842c382 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: A previous commit (#45616) broke the ci in OSS. It looks like that JSI is not working well in objective-c++ files when frameworks is enabled. We need to look into it further but we need to have green CI ## Changelog: [Internal] - Unblock CI Reviewed By: blakef Differential Revision: D60232011 fbshipit-source-id: b02ae163258786ce43cc11bc94420682661a6dd0
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60138415 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60138415 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Aug 13, 2024
…k#45616) Summary: Pull Request resolved: facebook#45616 We want to eventually route all js error handling through JsErrorHandler in bridgeless. This will help with that. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D60138415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We want to eventually route all js error handling through JsErrorHandler in bridgeless.
This will help with that.
Changelog: [Internal]
Differential Revision: D60138415