Skip to content

Delete removeOutstandingSurfacesOnDestruction flag#45630

Closed
mdvacca wants to merge 10 commits into
facebook:mainfrom
mdvacca:export-D60142272
Closed

Delete removeOutstandingSurfacesOnDestruction flag#45630
mdvacca wants to merge 10 commits into
facebook:mainfrom
mdvacca:export-D60142272

Conversation

@mdvacca
Copy link
Copy Markdown
Contributor

@mdvacca mdvacca commented Jul 24, 2024

Summary:
removeOutstandingSurfacesOnDestruction is safe to fully release, we are deleting the flag

changelog: [internal] internal

Differential Revision: D60142272

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 24, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@mdvacca mdvacca force-pushed the export-D60142272 branch from 7e40867 to 66f56ea Compare July 24, 2024 03:25
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@mdvacca mdvacca force-pushed the export-D60142272 branch from 66f56ea to e9cfd58 Compare July 24, 2024 03:41
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

2 similar comments
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@mdvacca mdvacca force-pushed the export-D60142272 branch from e9cfd58 to 49b46c4 Compare July 24, 2024 03:48
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@mdvacca mdvacca force-pushed the export-D60142272 branch from 49b46c4 to 24f4aab Compare July 24, 2024 03:56
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

mdvacca added 8 commits July 23, 2024 21:04
Summary:
Migrate enableCppPropsIteratorSetter to ReactNativeFeatureFlags

changelog: [internal] internal

Differential Revision: D60022936
Summary:
Migrate enableEagerRootViewAttachment to ReactNativeFeatureFlags

changelog: [internal] internal

Differential Revision: D60022934
Summary:
Migrate enableFabricLogs to ReactNativeFeatureFlags

changlog: [internal] internal

Differential Revision: D60022935
…reFlags

Summary:
Migrate unstable_enableTurboModuleSyncVoidMethods to ReactNativeFeatureFlags

changelog: [internal] internal

Differential Revision: D60022937
Summary:
Migrate traceTurboModulePromiseRejections to ReactNativeFeatureFlags

changelog: [internal] internal

Differential Revision: D60124027
Summary:
I'm deleting CoreFeatures::excludeYogaFromRawProps in favor of ReactNativeFeatureFlags::excludeYogaFromRawProps();

changelog: [internal] internal

Differential Revision: D60124448
Summary:
Delete CoreFeatures::enablePropIteratorSetter in favor of ReactNativeFeatureFlags::enablePropIteratorSetter

changelog: [internal] internal

Differential Revision: D60129358
mdvacca added 2 commits July 23, 2024 21:04
Summary:
Delete CoreFeatures class

changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags

Differential Revision: D60137380
Summary:
Pull Request resolved: facebook#45630

removeOutstandingSurfacesOnDestruction is safe to fully release, we are deleting the flag

changelog: [internal] internal

Differential Revision: D60142272
@mdvacca mdvacca force-pushed the export-D60142272 branch from 24f4aab to 3847141 Compare July 24, 2024 04:04
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D60142272

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 5386ece.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 28, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @mdvacca in 5386ece

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants