chore: Migrate FileUtilsTest.kt, NdkConfiguratorUtilsTest.kt and AgpConfiguratorUtilsTest.kt to AssertJ#45665
chore: Migrate FileUtilsTest.kt, NdkConfiguratorUtilsTest.kt and AgpConfiguratorUtilsTest.kt to AssertJ#45665henriquecicero wants to merge 7 commits into
Conversation
|
Hi @henriquecicero! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Hi, @cortinico, it's done. |
|
@henriquecicero can you please sign our CLA otherwise we won't be able to accept your contribution |
|
@cortinico, I did it just now. |
cortinico
left a comment
There was a problem hiding this comment.
Left a couple of suggestions to make it more idiomatic
|
@cortinico, thanks for the suggestions. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in f443511. |
|
This pull request was successfully merged by @henriquecicero in f443511 When will my fix make it into a release? | How to file a pick request? |
Summary:
Issue: #45596
Changelog:
[INTERNAL] [CHANGED] - Migrated to AssertJ within files FileUtilsTest.kt, NdkConfiguratorUtilsTest.kt and AgpConfiguratorUtilsTest.kt
Test Plan:
Run
./gradlew -p packages/gradle-plugin test