Handle NaN values in PixelUtil#45690
Closed
NickGerleman wants to merge 4 commits into
Closed
Conversation
Summary: We built these to be able to parse web style string values, but the types only allow object form, and the TypeScript type is wrong. Changelog: [Internal] Differential Revision: D60263730
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60265329 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60265329 |
NickGerleman
force-pushed
the
export-D60265329
branch
from
690febd to
8801a0a
Compare
Differential Revision: D60252277
Differential Revision: D60252276
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60265329 |
NickGerleman
force-pushed
the
export-D60265329
branch
from
8801a0a to
bf07145
Compare
Summary: Pull Request resolved: facebook#45690 ViewManager layer often uses `YogaConstants.UNDEFINED` (`NaN`) as null-state value. Teaching PixelUtil how to handle `NaN` values makes glue code around easier. Changelog: [Internal] Differential Revision: D60265329
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60265329 |
NickGerleman
force-pushed
the
export-D60265329
branch
from
bf07145 to
92e5805
Compare
Contributor
|
This pull request has been merged in 06e38b5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ViewManager layer often uses
YogaConstants.UNDEFINED(NaN) as null-state value. Teaching PixelUtil how to handleNaNvalues makes glue code around easier.Changelog: [Internal]
Differential Revision: D60265329