Expose more in CSSBackgroundDrawable#45691
Closed
NickGerleman wants to merge 3 commits into
Closed
Conversation
Summary: We built these to be able to parse web style string values, but the types only allow object form, and the TypeScript type is wrong. Changelog: [Internal] Differential Revision: D60263730
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60252276 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60252276 |
NickGerleman
force-pushed
the
export-D60252276
branch
from
f329464 to
78fcd5e
Compare
Differential Revision: D60252277
Summary: Pull Request resolved: facebook#45691 1. Add some accessors, so we can keep accessors and setters symetric 2. Use the shared BorderStyle enum added in last diff 3. Fix some missing invalidation on setting style Changelog: [Internal] Differential Revision: D60252276
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60252276 |
NickGerleman
force-pushed
the
export-D60252276
branch
from
78fcd5e to
7813fd8
Compare
Contributor
|
This pull request has been merged in 244e242. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Differential Revision: D60252276