fix[HostTargetSessionObserverTest.cpp]: call unsubscribe to cleanup resource#45701
Closed
hoxyq wants to merge 1 commit into
Closed
fix[HostTargetSessionObserverTest.cpp]: call unsubscribe to cleanup resource#45701hoxyq wants to merge 1 commit into
hoxyq wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60282464 |
…esource (facebook#45701) Summary: Pull Request resolved: facebook#45701 # Changelog: [Internal] One weird thing is that this test actually never runs for Android, so its only compiled. I am not sure why exactly this one produces an error during execution, given that the next test is almost identical. Nothing valuable from logcat, just a `SIGSEGV`. Since its something with memory, I've tried calling `unsubscribe`, same as in the next test to free memory before the test tear down (which should not run, because this test doesn't run). Differential Revision: D60282464
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60282464 |
Contributor
|
This pull request has been merged in b5a5e9d. |
Collaborator
|
This pull request was successfully merged by @hoxyq in b5a5e9d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
One weird thing is that this test actually never runs for Android, so its only compiled. I am not exactly sure why exactly this one produces an error during execution, given that the next test is almost idential.
Nothing valuable from logcat, just a
SIGSEGV. Since its something with memory, I've tried callingunsubscribe, same as in the next test to free memory before the test tear down (which should not run, because this test doesn't run).Differential Revision: D60282464