Make com.facebook.react.views.image nullsafe#45711
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60282604 |
Summary: Pull Request resolved: facebook#45711 Migrating this package in one go is proving harder than expected. Let's split this through in smaller parts: I'm first marking the package as nullsafe. Changelog: [Internal] [Changed] - Make `com.facebook.react.views.image` nullsafe Reviewed By: cipolleschi Differential Revision: D60282604
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60282604 |
cortinico
force-pushed
the
export-D60282604
branch
from
0597be6 to
92a3f37
Compare
Contributor
|
This pull request has been merged in f888f24. |
Collaborator
|
This pull request was successfully merged by @cortinico in f888f24 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrating this package in one go is proving harder than expected.
Let's split this through in smaller parts: I'm first marking the package as nullsafe.
Changelog:
[Internal] [Changed] - Make
com.facebook.react.views.imagenullsafeReviewed By: cipolleschi
Differential Revision: D60282604