Convert ReactImageManager to Kotlin#45722
Closed
cortinico wants to merge 3 commits into
Closed
Conversation
Summary: Migrating this package in one go is proving harder than expected. Let's split this through in smaller parts: I'm first marking the package as nullsafe. Changelog: [Internal] [Changed] - Make `com.facebook.react.views.image` nullsafe Differential Revision: D60282604
Summary: This moves the first remaining file inside views/image from Java to Kotlin Changelog: [Internal] [Changed] - Convert com/facebook/react/views/image/MultiPostprocessor.java to Kotlin Differential Revision: D60283278
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60285050 |
Summary: Pull Request resolved: facebook#45722 Splitting the ReactImageView convertion to another file, to see if this is causing further failures. Changelog: [Internal] [Changed] - Convert ReactImageManager to Kotlin Reviewed By: rshest Differential Revision: D60285050
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60285050 |
cortinico
force-pushed
the
export-D60285050
branch
from
47e65fe to
caf7916
Compare
Contributor
|
This pull request has been merged in a049a58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Splitting the ReactImageView convertion to another file, to see if this is causing further failures.
Changelog:
[Internal] [Changed] - Convert ReactImageManager to Kotlin
Differential Revision: D60285050