Skip to content

Disable "setAndroidLayoutDirection" in default feature flags #45753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 1 commit into from
Closed

Disable "setAndroidLayoutDirection" in default feature flags #45753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<abdee8d0b85b0d9940207b9cbe6d3f78>>
* @generated SignedSource<<fc363737bfe42515306043b836820f3f>>
*/

/**
Expand Down Expand Up @@ -79,7 +79,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun loadVectorDrawablesOnImages(): Boolean = false

override fun setAndroidLayoutDirection(): Boolean = true
override fun setAndroidLayoutDirection(): Boolean = false

override fun useImmediateExecutorInAndroidBridgeless(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<436dd66c962b5bd70cc574d573ddfc0a>>
* @generated SignedSource<<c849c35ad2b73c7c36017007eaee2851>>
*/

/**
Expand Down Expand Up @@ -140,7 +140,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool setAndroidLayoutDirection() override {
return true;
return false;
}

bool useImmediateExecutorInAndroidBridgeless() override {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ const definitions: FeatureFlagDefinitions = {
'Adds support for loading vector drawable assets in the Image component (only on Android)',
},
setAndroidLayoutDirection: {
defaultValue: true,
defaultValue: false,
description: 'Propagate layout direction to Android views.',
},
useImmediateExecutorInAndroidBridgeless: {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<b914ca36b2ab729f1262384d83b684b7>>
* @generated SignedSource<<46ea8a3a51ac64342484cc230727fca3>>
* @flow strict-local
*/

Expand Down Expand Up @@ -258,7 +258,7 @@ export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGett
/**
* Propagate layout direction to Android views.
*/
export const setAndroidLayoutDirection: Getter<boolean> = createNativeFlagGetter('setAndroidLayoutDirection', true);
export const setAndroidLayoutDirection: Getter<boolean> = createNativeFlagGetter('setAndroidLayoutDirection', false);
/**
* Invoke callbacks immediately on the ReactInstance rather than going through a background thread for synchronization
*/
Expand Down