Add Android RTL Coverage to ReactNativeCoreE2E tests#45758
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
Summary: We add a variant where we set RTL locales, and force RTL (because I think `Locale.getDefault()`, in RNTester, never returned desired value even after some build twiddling to include more res). I added a system property apart from the SharedPreferences for `I18nManager` forceRTL to make it easier to prepare test environment. Tests can opt into supporting only a single layout direction, but test against both by default, where we seem to be able to execute the tests successfully right now for the 53 turned on. Changelog: [Internal] Differential Revision: D60345614
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60345614 |
Contributor
|
This pull request has been merged in b415957. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in b415957 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Differential Revision: D60345614