chore: ☂️ Migrate GenerateCodegenSchemaTaskTest.kt to AssertJ#45807
Closed
omer-ayhan wants to merge 5 commits into
Closed
chore: ☂️ Migrate GenerateCodegenSchemaTaskTest.kt to AssertJ#45807omer-ayhan wants to merge 5 commits into
omer-ayhan wants to merge 5 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
hello @cortinico 👋 this PR is ready for a review🚀 |
facebook-github-bot
added
the
Shared with Meta
cortinico
requested changes
Jul 30, 2024
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Please include the suggested changes
| assertEquals(setOf(File(jsRootDir, "afolder/includedfile.js")), task.jsInputFiles.files) | ||
| assertThat(task.jsInputFiles.dir).isEqualTo(jsRootDir) | ||
| assertThat(task.jsInputFiles.excludes).isEqualTo(setOf("**/build/**/*")) | ||
| assertThat(task.jsInputFiles.files).hasSize(1) |
Contributor
There was a problem hiding this comment.
This is unnecessary now 👍
Contributor
Author
There was a problem hiding this comment.
should I delete those assertions? Which means you don't need assertion for task.jsInputFiles? @cortinico
Contributor
There was a problem hiding this comment.
I meant only the size assertion
cortinico
approved these changes
Jul 31, 2024
| assertEquals(setOf(File(jsRootDir, "afolder/includedfile.js")), task.jsInputFiles.files) | ||
| assertThat(task.jsInputFiles.dir).isEqualTo(jsRootDir) | ||
| assertThat(task.jsInputFiles.excludes).isEqualTo(setOf("**/build/**/*")) | ||
| assertThat(task.jsInputFiles.files).hasSize(1) |
Contributor
There was a problem hiding this comment.
I meant only the size assertion
…lin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt
…lin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 575ab78. |
Collaborator
|
This pull request was successfully merged by @omer-ayhan in 575ab78 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: #45596
Changelog:
[INTERNAL] [CHANGED] - Migrate
GenerateCodegenSchemaTaskTest.ktto AssertJ testing libraryTest Plan:
Run
./gradlew -p packages/gradle-plugin test