Android: Fix uploading GIF URI

[s77rt]

Summary:

In Android, when constructing a multipart body for a file and that file source is a uri (base64-encoded) we do the following:

1. Decode the base64 string into bytes
2. Create a bitmap object
3. Compress the bitmap object as PNG into new bytes

The process does an unnecessary work (bytes -> bitmap -> bytes) and creates unexpected results e.g. a GIF file will be converted into PNG when uploaded. This PR removes the unnecessary steps (2 and 3).

Changelog:

[ANDROID] [FIXED] - Fix uploading GIF URI

Test Plan:

1. Upload a GIF; use URI (base64-encoded)
2. Verify that the uploaded file is a GIF

const formData = new FormData();
formData.append('photo', {
  uri: GIFURI,
  type: 'image/gif',
  name: 'photo.gif',
});

fetch(UPLOAD_URL,
{
    body: formData,
    method: "POST",
}):

Before	After
Screen.Recording.2024-07-30.at.8.50.51.PM.mov	Screen.Recording.2024-07-30.at.8.58.21.PM.mov

[tdn120]

Can you please take a look at #33675 and confirm the steps are unnecessary, given that context?

[s77rt]

@tdn120 From that issue

I think converting the dataUri to Bitmap is necessary as there is no method that lets us convert the dataUri to inputStream directly

That's not the case. The decoded bytes can be used directly.

[facebook-github-bot]

@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@tdn120 merged this pull request in 48669af.

[react-native-bot]

This pull request was successfully merged by @s77rt in 48669af

^{When will my fix make it into a release? | How to file a pick request?}

[s77rt]

@tdn120 Thank you!