Declare onUserDrivenAnimationEnded on Old Arch#45838
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60507812 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60507812 |
cipolleschi
force-pushed
the
export-D60507812
branch
from
343a03b to
e54579f
Compare
Summary: Pull Request resolved: facebook#45838 Some Internal tests in the old architecture were failing after landing [facebook#45414](facebook#45414) because the `RCTNativeAnimatedModule` in the old architecture was not declaring the event. This change fixes it by declaring the event that is never fired in the Old Architecture as it is not needed. ## Changelog [iOS][Added] - Declare the `onUserDrivenAnimationEnded` in the old Architecture Reviewed By: sammy-SC Differential Revision: D60507812
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60507812 |
cipolleschi
force-pushed
the
export-D60507812
branch
from
e54579f to
961416b
Compare
Contributor
|
This pull request has been merged in f8c13f6. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in f8c13f6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some Internal tests in the old architecture were failing after landing #45414 because the
RCTNativeAnimatedModulein the old architecture was not declaring the event.This change fixes it by declaring the event that is never fired in the Old Architecture as it is not needed.
Changelog
[iOS][Added] - Declare the
onUserDrivenAnimationEndedin the old ArchitectureDifferential Revision: D60507812